tahonermann requested changes to this revision.
tahonermann added inline comments.
This revision now requires changes to proceed.
Herald added a subscriber: wangpc.
================
Comment at: clang/lib/Frontend/ASTConsumers.cpp:192-198
+ bool HandleTopLevelDecl(DeclGroupRef D) override {
for (DeclGroupRef::iterator I = D.begin(), E = D.end(); I != E; ++I)
HandleTopLevelSingleDecl(*I);
return true;
}
void HandleTopLevelSingleDecl(Decl *D);
----------------
Indentation is still inconsistent here.
I suggest following the indentation used for `StackAddrEscapeChecker` in
`clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp`; Don't indent
the `ASTViewer` class definition within the unnamed namespace and do indent the
class members.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153892/new/
https://reviews.llvm.org/D153892
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
