yaxunl marked an inline comment as done.
yaxunl added inline comments.

================
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:86
+def warn_drv_multi_gpu_arch : Warning<
+  "multiple %0 architecture are detected: %1; only the first one is used for "
+  "'%2'">, InGroup<MultiGPU>;
----------------
arsenm wrote:
> s/architecture/architectures/
> 
> Maybe should stick to the "device" terminology opencl uses
`multiple devices` is ambiguous since it could mean multiple devices of the 
same GPU architecture. `multiple architectures` is not ambiguous.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154531/new/

https://reviews.llvm.org/D154531

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to