shafik added a comment.

I did not look at this in detail but I don't think this approach is correct. I 
fixed this for constant evaluation the other day and you can find the details 
here: D130058 <https://reviews.llvm.org/D130058>

The test suite I wrote should be sufficient for you to validate your approach 
against.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153954/new/

https://reviews.llvm.org/D153954

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to