avl added inline comments.
================ Comment at: llvm/test/tools/llvm-dwarfutil/ELF/X86/mirror-permissions-unix.test:2 +## The Unix version of this test must use umask(1) because +## llvm-darfutil respects the umask in setting output permissions. +## Setting the umask to 0 ensures deterministic permissions across ---------------- ================ Comment at: llvm/unittests/Support/raw_ostream_test.cpp:499 + ErrorOr<llvm::sys::fs::perms> Perms = llvm::sys::fs::getPermissions(Path); + ASSERT_TRUE(!!Perms); + EXPECT_EQ(0, *Perms & llvm::sys::fs::all_exe); ---------------- !! looks a bit unclear. Probably check it in more explicit way? EXPECT_TRUE(Perms && !(*Perms & llvm::sys::fs::all_exe)); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153652/new/ https://reviews.llvm.org/D153652 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
