xen0n marked 2 inline comments as done. xen0n added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:732 +def warn_drv_loongarch_conflicting_mabi : Warning< + "the -mabi setting '%0' conflicts with that implied by -m*-float (%1); using %1">, + InGroup<OptionIgnored>; ---------------- MaskRay wrote: > This is not called `setting`. Use `value` > > It seems that `ignoring -mabi value '%0' as it conflicts ...` is more > conventional. Sounds reasonable. I've checked other similar diagnostics text and it seems your suggestion is stylistically more consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153707/new/ https://reviews.llvm.org/D153707 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
