yronglin marked an inline comment as done.
yronglin added inline comments.
================
Comment at: clang/lib/AST/ExprConstant.cpp:4988
+ if (SS->getCond()->containsErrors() ||
+ !EvaluateDependentExpr(SS->getCond(), Info))
return ESR_Failed;
----------------
erichkeane wrote:
> It seems to me that the 'better' solution is to make EvaluateDependentExpr
> (or one of its children) be RecoveryExpr aware, and result in a failed value
> instead. That way we get this 'fix' for more than just switch statements.
Thanks for your review!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153296/new/
https://reviews.llvm.org/D153296
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
