rjmccall added a comment.

Hmm.  Why are we clearing the FP pragma stack instead of saving the old context 
onto it and then restoring after instantiation?  I don't think semantic 
analysis ever depends on enclosing members of the stack, does it?

Clearing the entire stack might not matter much if we're at the end of the 
translation unit, which is the normal time to instantiate things, but it would 
matter if we're eagerly instantiating within the translation unit, which we 
have to do for various reasons, including explicit instantiation and 
`constexpr`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143241/new/

https://reviews.llvm.org/D143241

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to