efriedma added a comment. Even if we do decide we have to use platform-specific facilities because there's no suitable library, I think we should at least have a hardcoded set of encodings we recognize, so we aren't passing arbitrary encoding names directly from the command-line to the iconv() call.
Do you have a list of specific encodings you care about? In D153418#4440420 <https://reviews.llvm.org/D153418#4440420>, @cor3ntin wrote: > In D153418#4438766 <https://reviews.llvm.org/D153418#4438766>, @efriedma > wrote: > >> Can we use the existing conversion utilities in LLVM for UTF-16/UTF-32? > > Not sure how useful this would be, UTF-16/UTF-32 facilities are used directly > when they are needed, and utf-16 source input files are rare. UTF-16 source files see some usage on Windows. Not sure exactly how common it is, but I think certain versions of Visual Studio defaulted to UTF-16... obviously, people who know what they're doing avoid encoding their files that way. I just noted it because some of the unit-tests were using UTF-16/UTF-32. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153418/new/ https://reviews.llvm.org/D153418 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
