MaskRay added a comment. In D145849#4430870 <https://reviews.llvm.org/D145849#4430870>, @ilammy wrote:
> In D145849#4412286 <https://reviews.llvm.org/D145849#4412286>, @MaskRay wrote: > >> However, `Triple.isMacOSX()` is allowed before the feature actually works >> and `compiler-rt/test/xray/lit.cfg.py` tests it. > > I have some patches for `compiler-rt` cooking, fixing the build for AArch64. > Should those go in first, before `clang` is ultimately allowed to use > `-fxray-instrument` when targeting AArch64, so that everything works out of > the box? > > For me, Clang is able to compile binaries with XRay sections (with this > change), but I have `compiler-rt` disabled and not linked in, since it's not > possible to build it for AArch64 yet. > > I thought it could be done separately. I was not aware of those tests in > compiler-rt, checking all archs. > > I guess the build should be fixed first, then this change should > simultaneously allow clang to target AArch64 and update compiler-rt's > expectations of what works. > > How does that sound to you? Since Mach-O porting is supposed to be done soon, I think landing this change is fine. This patch should make fixing the underlying issue easier as we don't need to locally patch XRayArgs.cpp... I think D152661 <https://reviews.llvm.org/D152661> is very much desired and ideally landed before other fixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145849/new/ https://reviews.llvm.org/D145849 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
