AMS21 added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/performance/NoexceptSwapCheck.cpp:21
+ Finder->addMatcher(
+ functionDecl(unless(isImplicit()), unless(isDeleted()), hasName("swap"))
+ .bind("decl"),
----------------
PiotrZSL wrote:
> i dont think that swap functions can be deleted
All functions can be deleted. See
[cppreference](https://en.cppreference.com/w/cpp/language/function#Deleted_functions)
```
void swap(int, int) = delete;
```
Should be valid C++ and not give a no-noexcept warning, so we need to exclude
it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148697/new/
https://reviews.llvm.org/D148697
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
