MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land.
LGTM. Glad that my comment on https://github.com/llvm/llvm-project/issues/23983 might bring attention to users. I'd like to make my stance softer: if we find `CLICOLOR_FORCE` useful, we can implement it later. I don't mind how we handle `NO_COLOR=1 CLICOLOR_FORCE=1`. This seems invalid input from the user and making either option win should be fine (I'd prefer that `NO_COLOR` wins.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152285/new/ https://reviews.llvm.org/D152285 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
