brendandahl marked 2 inline comments as done.
brendandahl added inline comments.


================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7638
+  D->addAttr(::new (S.Context) WebAssemblyAsyncAttr(S.Context, AL));
+  D->addAttr(UsedAttr::CreateImplicit(S.Context));
+}
----------------
erichkeane wrote:
> We should probably document that this forces the function to be emitted as 
> well.
I've removed this since we won't actually always want these functions 
preserved. I've changed the linker to now put a tombstone in the async section 
instead. I also added a new test for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150803/new/

https://reviews.llvm.org/D150803

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to