cor3ntin marked 9 inline comments as done.
cor3ntin added inline comments.
================
Comment at: clang/test/SemaCXX/cxx2b-consteval-propagate.cpp:8
+
+namespace examples {
+
----------------
aaron.ballman wrote:
> Fznamznon wrote:
> > cor3ntin wrote:
> > > Fznamznon wrote:
> > > > These examples exactly match the ones provided by P2564R3, should they
> > > > be in a separate test in `CXX` directory then?
> > > I don't have a string preference, should we move the paper examples? the
> > > whole file?
> > I meant the paper examples. I don't have a strong preference too, so in
> > case it doesn't matter where the test actually is, please ignore this
> > comment.
> Because it's voted in as a DR, we should have a test in `clang/test/CXX/drs/`
> with the appropriate DR number markings (and then regenerate the DR status
> page as well).
I'm not sure core makes dr numbers for papers
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151094/new/
https://reviews.llvm.org/D151094
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
