kiranchandramohan added inline comments.
================ Comment at: flang/lib/Lower/Bridge.cpp:271 + bridge{bridge}, foldingContext{bridge.createFoldingContext()}, + ompRequiresFlags{mlir::omp::ClauseRequires::none} {} virtual ~FirConverter() = default; ---------------- Is this set anywhere? If not is it required? Can this be made available through the bridge? ================ Comment at: flang/lib/Lower/Bridge.cpp:2234 + /// Extract information from OpenMP declarative constructs + void analyzeOpenMPDeclarative( + const Fortran::parser::OpenMPDeclarativeConstruct &ompDecl) { ---------------- Can this function be moved to OpenMP.cpp? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits