erichkeane added inline comments.
================ Comment at: clang/lib/Sema/SemaExprCXX.cpp:5620 + if (Kind == clang::TT_TypePackIndex) + return EvaluateIntegralTypeTrait(*this, Kind, KWLoc, Args, RParenLoc, ---------------- cjdb wrote: > erichkeane wrote: > > I realize this is the 1st, but this seems like it is going to be a > > maintenance pain. Can you at least split this into a static-function of > > `IsIntegralTypeTrait` that we can use later with table-gen if this gets out > > of hand? > Done, but in D152034. It's a change that should happen independently of this > one IMO. Thanks! THat looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151952/new/ https://reviews.llvm.org/D151952 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
