efriedma added inline comments.
================ Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1209 + return VisitCastExpr(I, T); + } + llvm::Constant *VisitCXXFunctionalCastExpr(CXXFunctionalCastExpr *C, QualType T) { ---------------- ConstExprEmitter should inherit an identical implementation of VisitImplicitCastExpr from StmtVisitor, I think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151587/new/ https://reviews.llvm.org/D151587 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits