rsmith requested changes to this revision.
rsmith added inline comments.
This revision now requires changes to proceed.
================
Comment at: clang/lib/Parse/ParseTentative.cpp:1553-1554
return TPResult::Error;
- if (Tok.isNot(tok::identifier))
+ if (NextToken().isNot(tok::identifier))
break;
}
----------------
This doesn't seem correct to me. If we had `scope::foo bar`, and we annotate
`scope::foo` as a type, then this will get confused by the next token now being
an (unrelated) identifier. This code is trying to detect if an annotation was
performed, so I think it intended to check if the current token's kind has
changed, like is done on line 1295.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134334/new/
https://reviews.llvm.org/D134334
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
