yaxunl added inline comments.

================
Comment at: clang/include/clang/Sema/TemplateDeduction.h:338
 public:
-  TemplateSpecCandidateSet(SourceLocation Loc, bool ForTakingAddress = false)
       : Loc(Loc), ForTakingAddress(ForTakingAddress) {}
----------------
rsmith wrote:
> Do we need to allow the location to be set after the set is created? Giving 
> this type an additional state where the location is absent seems error prone, 
> and in the uses below it looks easy to set the location in the caller instead 
> of the callee.
I will fix this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150212/new/

https://reviews.llvm.org/D150212

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to