Sedeniono added a comment. @MyDeveloperDay Thanks for the positive review. Regarding https://github.com/llvm/llvm-project/issues/56352 and the Beyoncé Rule, the original fix for the crash actually added a test (see the changes made at that time <https://github.com/llvm/llvm-project/commit/14c30c70c4595d8f410c74a72357a5a31fdd5507#diff-6b071715395935c160d75e1e8d65534f118a4c1495b74981555e6d67273cccecR617>). The test also still works, since it crashes/debug-asserts with just the reintroduction of the `resize()`. That caused me to dig some more and I came up with the `A.Level = B.Level;` part of the fix to fix the crash. The `if (!Line.InPPDirective)` part was because of another failing test.
Since this is my first submission to llvm, I do not have commit access. So someone else has to commit and push this into main. Regarding name and mail: If you use "Sedenion" as name and "39583823+sedeni...@users.noreply.github.com" as mail, I guess github will attribute the commit to my github account <https://github.com/Sedeniono>? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151047/new/ https://reviews.llvm.org/D151047 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
