craig.topper added a comment.

In D150646#4351981 <https://reviews.llvm.org/D150646#4351981>, @aidengrossman 
wrote:

> Thanks for notifying me of this. I've reverted it as I don't have too much 
> time currently to thoroughly go through things and I don't want to keep you 
> blocked. Essentially, the built-in for `__cpuidex` on Windows platforms 
> landed in https://reviews.llvm.org/D121653 which is conflicting with this new 
> implementation (from what I can gather). If that's the issue though, it's 
> interesting that it doesn't seem like there are any conflicts between the 
> `__cpuid` builtin and the one defined in `cpuid.h`. Hoping to get a fix up 
> (relatively) soon but not sure currently exactly what it will look like. 
> @glandium Do you have a link to a source file that ends up triggering this 
> error in Firefox? I'd be interested in seeing the context.

I think __cpuid doesn't conflict because it's a macro in cpuid.h rather than a 
function definition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150646/new/

https://reviews.llvm.org/D150646

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to