domada added a comment.

In D150354#4337148 <https://reviews.llvm.org/D150354#4337148>, @awarzynski 
wrote:

> All in all LGTM, but I'm not sure whether Flang should be defaulting to 
> OpenMP 5.0. AFAIK, that's not supported yet.

If you wish I can set to OpenMP 4.5. But then we need to have two separate 
flags in clang/include/clang/Driver/Options.td (one for clang and the second 
one for flang).



================
Comment at: clang/lib/Driver/ToolChains/Flang.cpp:34
+  Args.AddAllArgs(CmdArgs, {options::OPT_ffixed_form,
+                            options::OPT_ffree_form,
+                            options::OPT_ffixed_line_length_EQ,
----------------
awarzynski wrote:
> Is this clang-format? Looks like a big block of unrelated changes (not 
> against it).
Yes, this is output of clang format.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150354/new/

https://reviews.llvm.org/D150354

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to