MyDeveloperDay added inline comments.
================
Comment at: clang/unittests/Format/ObjCPropertyAttributeOrderFixerTest.cpp:156
+
+ for(auto const& Attribute: getAllObjCAttributes()) {
+ Style.ObjCPropertyAttributeOrder = { "FIRST", Attribute, "LAST" };
----------------
I'm not a massive fan of writing looping logic in tests, I prefer just to lay
them all out so when it fails I know precisely where and why. I don't want to
have to debug a failure. I want it to be very obvious. My concern here in the
first place is if someone makes one of your words a keyword further down the
link, this is why you should have specific examples.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150083/new/
https://reviews.llvm.org/D150083
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
