tahonermann added subscribers: lenary, foad.
tahonermann added a comment.
> I was following the LLVM contribution guidelines to use git clang-format, but
> I understand the importance of maintaining existing code styles that may be
> altered by git-clang format.
The guidelines are slightly in conflict in that regard so, yeah, its a
judgement call.
I added two more suggested edits targeting some comments.
This looks good to me, but I think we should make sure AMD and ARM folks are
aware of the change. @foad, @lenary, any concerns?
================
Comment at: clang/include/clang/Basic/TargetInfo.h:650
- /// Determine whether the _BFloat16 type is supported on this target.
- virtual bool hasBFloat16Type() const { return HasBFloat16; }
+ /// Determine whether the _BF16 type is supported on this target.
+ virtual bool hasBF16Type() const { return HasBF16; }
----------------
================
Comment at: clang/include/clang/Basic/arm_neon_incl.td:240
// F: change to floating category.
-// B: change to BFloat16
+// B: change to BF16
// P: change to polynomial category.
----------------
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150291/new/
https://reviews.llvm.org/D150291
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
