shchenz accepted this revision as: shchenz. shchenz added a comment. This revision is now accepted and ready to land.
I think this is correct. DWARF spec indicates that DWARF64 should not be set as default. So it is right to change to DWARF32 by default for integrated-as mode for XCOFF64. LGTM with one nit. ================ Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:403 + ((TT.isOSBinFormatELF() || + (TT.isOSBinFormatXCOFF() && UseIntegratedAs)) && + (Asm->TM.Options.MCOptions.Dwarf64 || MMI->getModule()->isDwarf64())) || ---------------- Nit: Maybe we can use a variable to contain the value for `TT.isOSBinFormatXCOFF()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150181/new/ https://reviews.llvm.org/D150181 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
