nridge added inline comments.
================ Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:400 + bool ActiveKindLookup[static_cast<size_t>(HighlightingKind::LastKind) + 1]; + uint32_t ActiveModifiersMask; +}; ---------------- daiyousei-qz wrote: > nridge wrote: > > For good measure, let's `static_assert(HighlightingModifier::LastModifier < > > 32)` > IIRC, we already have such static_assert after the definition of > HighlightingModifier in SemanticHighlight.h Good point, I overlooked that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148489/new/ https://reviews.llvm.org/D148489 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
