aaron.ballman added a comment.

Do you have some performance measurement numbers for how much benefit we get 
from the changes?



================
Comment at: clang/lib/Sema/SemaExpr.cpp:19195
+
+  // tryCaptureVariable is called ever ytime a DeclRef is formed,
+  // it can therefore have non-negigible impact on performances.
----------------



================
Comment at: clang/lib/Sema/SemaExpr.cpp:19199
+  // we can bailout early.
+  if(CapturingFunctionScopes == 0 && (!BuildAndDiagnose || VarDC == DC))
+    return true;
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150038/new/

https://reviews.llvm.org/D150038

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to