barannikov88 added a comment. I think it should be ready for review now.
One point to note. I didn't follow IWYU rule in target *.cpp files -- they include the smallest set of headers for now. My memory suggests me that IWYU is a requirement, but I couldn't find a proof in the coding standard. It now says "include as little as possible" <https://llvm.org/docs/CodingStandards.html#include-as-little-as-possible> and further elaborates: > You must include all of the header files that you are using — you can include > them either directly **or indirectly through another header file**. I also think it is easier to fix compiler errors afterwards than to try to figure out the necessary or reasonable set of includes. Please let me know if you disagree. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
