aaron.ballman added a comment. In D149553#4312788 <https://reviews.llvm.org/D149553#4312788>, @Mordante wrote:
> In D149553#4310478 <https://reviews.llvm.org/D149553#4310478>, @aaron.ballman > wrote: > >> Thank you for working on this! The Clang changes are mostly all good, but I >> think we should hold off on changing the value of `__cplusplus` for the >> moment as it's not set in stone in the standard yet (I thought it was >> though, so I'm checking with the editor). > > I noticed the same and I was wondering whether I should contact the editor. I > noticed some approved papers also have not been merged yet. (These papers are > still open issues in the paper repository.) > > I'll wait a few days to see whether the draft gets updated otherwise I revert > the macro change. > > I would be very surprised if the macro gets a different value, that's why I > already bumped it. I heard back from the editor yesterday and he said that the macro would be replaced with an appropriate value for the DIS, and that he hopes to ensure that value is published in the next meeting mailing (which would be roughly May 15). So I think we can either wait until that mailing comes out and see if it has a concrete value to land these changes, or we can land everything but the macro value changes and deal with that in a follow up (this might be easier due to rebasing woes given how large this patch is). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149553/new/ https://reviews.llvm.org/D149553 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
