mikecrowe added inline comments.
================
Comment at:
clang-tools-extra/test/clang-tidy/checkers/modernize/printf-to-std-print-convert.cpp:289
+ // CHECK-MESSAGES: [[@LINE-1]]:3: warning: Replace 'printf' with
'std::print' [modernize-printf-to-std-print]
+ // CHECK-FIXES: std::print("Integer {} from signed char\n", sc);
+
----------------
mikecrowe wrote:
> This requires a cast to `unsigned char`. It appears that
> `Arg->getType()->isSignedIntegerType()` inside the `uArg` case is returning
> `false` for `signed char`, which means that it doesn't get one. Strange!
> This requires a cast to `unsigned char`. It appears that
> `Arg->getType()->isSignedIntegerType()` inside the `uArg` case is returning
> `false` for `signed char`, which means that it doesn't get one. Strange!
Operator error. Apologies for the noise. :(
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149280/new/
https://reviews.llvm.org/D149280
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
