MaskRay added inline comments.
================ Comment at: clang/test/Driver/mips-cpu64abi32.c:1 +// Check handling the CPU is 64bit while ABI is O32. +// when build for MIPS platforms. ---------------- Use `///` for non-CHECK non-RUN comments. ================ Comment at: clang/test/Driver/mips-cpu64abi32.c:5 +// abi-n32 +// RUN: %clang -c %s -target mips-linux-gnu -mabi=n32 -o - \ +// RUN: | llvm-readelf -h - \ ---------------- `-target ` is legacy. Use `--target=`. Driver tests should not test code generation. Just check that `%clang ...` passes the right options to cc1. ================ Comment at: clang/test/Driver/mips-cpu64abi32.c:9 +// CHECK-ABI-N32: abi2 +// +// abi-64 ---------------- Don't add `^//$` lines. Just use a blank line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146269/new/ https://reviews.llvm.org/D146269 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
