erichkeane added a comment. Generally ok with all of this, but want some time to think about it/give aaron/etc time to see it.
================ Comment at: clang/include/clang/Basic/TokenKinds.def:751 +// Keywords defined by Attr.td. +#define KEYWORD_ATTRIBUTE(X) KEYWORD(X, KEYALL) +#include "clang/Basic/AttrTokenKinds.inc" ---------------- Probably should be: `#ifndef KEYWORD_ATTRIBUTE` here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148700/new/ https://reviews.llvm.org/D148700 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits