shafik added a comment. I am mostly done but others should also look at this.
================ Comment at: clang/lib/Sema/SemaInit.cpp:5348 + }; + ExprResult ER = CreateExprResult(); + if (InitExpr) ---------------- Why not just use a conditional expression here or alternatively just turn it into an IIILE? ================ Comment at: clang/lib/Sema/SemaInit.cpp:5394 + ResultType = S.Context.getConstantArrayType( + AT->getElementType(), llvm::APInt(/*numBits=*/32, ArrayLength), nullptr, + ArrayType::Normal, 0); ---------------- ================ Comment at: clang/lib/Sema/SemaInit.cpp:5421 + InitializationKind SubKind = InitializationKind::CreateValue( + Kind.getLocation(), Kind.getLocation(), Kind.getLocation(), true); + if (!HandleInitializedEntity(SubEntity, SubKind, nullptr)) ---------------- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
