daiyousei-qz added inline comments.
================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:1281
}
+std::optional<HighlightingKind>
+highlightingKindFromString(llvm::StringRef Name) {
----------------
I'm not sure if we should parse the enums here or in parsing configs using
`EnumSwitch`. The problem is that I don't want to introduce dependencies to
"SemanticHighlighting.h" in "ConfigCompile.cpp".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148489/new/
https://reviews.llvm.org/D148489
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
