hans added a comment. In D147256#4262002 <https://reviews.llvm.org/D147256#4262002>, @zequanwu wrote:
> In D147256#4261949 <https://reviews.llvm.org/D147256#4261949>, @hans wrote: > >>> Well, MSVC cl removes redundant dots so we shouldn't remove >>> llvm::sys::path::remove_dots. >> >> Could we do the `remove_dots` on the Clang side, where we can decide based >> on the LangOpts? > > Yes, we can do that. Is there a reason to favor there over here? At here, the > object path in llc output can also benefits from `remove_dots`, not just > clang. The benefit is that if we do it in Clang, we can just look at the LangOpts and don't have to add a new target option, command line flag etc. For llc, since it's an internal tool, I think it would be fine to just use the name as given. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147256/new/ https://reviews.llvm.org/D147256 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
