craig.topper added inline comments.
================
Comment at: clang/test/CodeGen/RISCV/ntlh-intrinsics/riscv32-zihintntl.c:19
+typedef signed short v8ss __attribute__((vector_size(16)));
+typedef signed char v16sc __attribute__((vector_size(16)));
+v4si v4si1, v4si2;
----------------
What about the rvv builtin types for scalable vectors?
================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:15347
+ if (NontemporalLevel == 1)
+ NontemporalLevel = 5;
+
----------------
Should we default Nontemporal level to 5 before looking at
riscv-nontemporal-domain? Then only 2-5 are legal values?
================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:2635
+ static const std::pair<MachineMemOperand::Flags, const char *> TargetFlags[]
=
+ {{MONontemporalBit0, "riscv-non-temporal-domain-bit-0"},
+ {MONontemporalBit1, "riscv-non-temporal-domain-bit-1"}};
----------------
This uses "non-temporal" and the metadata uses "nontemporal". I think we should
be consistent.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143364/new/
https://reviews.llvm.org/D143364
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
