michael-g-matthews added a comment. I am also a little confused by what you mean @MyDeveloperDay. The options that were removed contained incorrect documentation (listing ASCIIbetical as CaseInsensitive). The enum documentation immediately after was however correct, so the documentation was self-contradictory. Instead of removing the options, I could have just fixed the typo, but then you have redundant documentation. In that case, if there are changes in the future, a dev will have to make documentation changes in two places instead of one. In my opinion, this was the cleaner option, but I am willing to acquiesce if the other option is preferable
CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147894/new/ https://reviews.llvm.org/D147894 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
