carlosgalvezp added a comment.
Looks good, small comments!
================
Comment at: clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp:183
+ if (Method->isLambdaStaticInvoker() ||
+ (IgnoreVirtual && Method->isVirtual()))
return;
----------------
Since these 2 conditions are unrelated, I believe it's better to put them in
separate ifs:
```
if (IgnoreVirtual && Method->isVirtual())
return;
if (Method->isLambdaStaticInvoker())
return;
```
================
Comment at:
clang-tools-extra/test/clang-tidy/checkers/misc/unused-parameters-virtual.cpp:4
+
+struct Class {
+ int f(int foo) {
----------------
We typically call it `Base`. `Class` can also be confusing since it's a
`struct` ;)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147918/new/
https://reviews.llvm.org/D147918
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
