sstwcw added inline comments.
================ Comment at: clang/docs/tools/dump_format_style.py:72 - subtype, napplied = re.subn(r'^std::vector<(.*)>$', r'\1', typestr) - if napplied == 1: - return 'List of ' + pluralize(to_yaml_type(subtype)) + match = re.match(r'std::vector<(.*)>$', typestr) + if match: ---------------- rymiel wrote: > jp4a50 wrote: > > I changed this from `subn` to `match` here since it's just a simpler way of > > expressing the same thing. > (Just FYI, those pythons sources are pretty ancient and untouched, I planned > on refactoring the whole thing using more modern, idiomatic Python but then > concluded that it's not really necessary) Is curdeius the one who knows about the Python scripts and the YAML parser? Did he move on to meaningful things? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146101/new/ https://reviews.llvm.org/D146101 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
