aaron.ballman added a comment. In D147661#4249696 <https://reviews.llvm.org/D147661#4249696>, @aaron.ballman wrote:
> I don't think there's a way to test this change, unfortunately. However, I > think this exposed a bigger concern, which is that `AttributeCommonInfo` has > some single-argument constructors that are not `explicit` so that we don't > run into this issue again. However, fixing that entails changing clang's > tablegen, so I don't think it should block these changes. I threw together a patch to make the constructors `explicit` and the only two compile failures I have are with what you're fixing in this patch. If you'd like, I can commandeer this patch and subsume it with the larger refactor. Alternatively, we can land this (I'd drop the test though) and I can rebase on top of your changes. Either is fine by me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147661/new/ https://reviews.llvm.org/D147661 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
