pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for working on it!
================
Comment at: clang/lib/Headers/immintrin.h:294
+/// \param __p
+/// Pointer to a 16-bit location to place the random value.
+/// \returns 1 if the value was successfully generated, 0 otherwise.
----------------
memory location
================
Comment at: clang/lib/Headers/immintrin.h:294
+/// \param __p
+/// Pointer to a 16-bit location to place the random value.
+/// \returns 1 if the value was successfully generated, 0 otherwise.
----------------
pengfei wrote:
> memory location
Nit: I saw others prefer to `A pointer`
================
Comment at: clang/lib/Headers/immintrin.h:309
+/// \param __p
+/// Pointer to a 32-bit location to place the random value.
+/// \returns 1 if the value was successfully generated, 0 otherwise.
----------------
ditto.
================
Comment at: clang/lib/Headers/immintrin.h:324
+/// \param __p
+/// Pointer to a 64-bit location to place the random value.
+/// \returns 1 if the value was successfully generated, 0 otherwise.
----------------
ditto.
================
Comment at: clang/lib/Headers/immintrin.h:414
+/// \param __V
+/// Value to use for the lower 32 bits of the FS base register.
static __inline__ void __attribute__((__always_inline__, __nodebug__,
__target__("fsgsbase")))
----------------
Nit: I saw others prefer to `A 32-bit integer value`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147461/new/
https://reviews.llvm.org/D147461
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
