owenpan requested review of this revision.
owenpan marked an inline comment as done.
owenpan added inline comments.


================
Comment at: clang/include/clang/Format/Format.h:4299
            InsertNewlineAtEOF == R.InsertNewlineAtEOF &&
            IntegerLiteralSeparator.Binary == R.IntegerLiteralSeparator.Binary 
&&
+           IntegerLiteralSeparator.BinaryMinDigits ==
----------------
HazardyKnusperkeks wrote:
> Could we move that to (a not yet existing) 
> `IntegerLiteralSeparatorStyle::operator==`?
Good point.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147111/new/

https://reviews.llvm.org/D147111

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to