augusto2112 marked 4 inline comments as done.
augusto2112 added a comment.

> Should there be some check that that symbol exists? (the current test uses 
> the unmangled name "bar" for instance - which gives the wrong impression?)

You mean as part of the attribute validation?

> What would happen if, instead, these trampolining functions were annotated 
> nodebug? I guess then you wouldn't have the top level one as an entry point 
> for the user, as there would be no debug info for it?

These trampoline functions can call other functions as part of their setup, so 
annotating them with nodebug wouldn't guarantee that the debugger would be able 
to step through to the correct place. Additionally, you wouldn't be able to 
refer to them in LLDB expression evaluation either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146595/new/

https://reviews.llvm.org/D146595

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to