Hi Chuanqi > On 17 Mar 2023, at 02:49, Chuanqi Xu via Phabricator > <revi...@reviews.llvm.org> wrote: > > ChuanqiXu added a comment. > > (I don't why I can't send emails in the original mail address. It told me > that your email addressed is not recorded by MX, while I don't know what is > MX. So I tried to reply your email here)
No idea, you have replied to emails to this address before. > This FIXME was added 6 years ago for Modules TS. > (https://github.com/llvm/llvm-project/commit/becb92dec85924969ac0c3b049e0a74def431453). > And I moved the test simply without modifying it actually. > > And I guess it may refer to the problem we are discussing. The spec says the > implementation unit will import the primary module interface implicitly. Also “as if imported”. .. and https://reviews.llvm.org/D126959 actually completes that by adding an import decl and adding the primary module interface to the imported modules. Let’s deal with D126959 separately since we already have a review thread. > But the current implementation doesn't **import** it actually but loading it. > This is inconsistent with the wording and it is not consistent with the > design intention in clang. > It resulted some problems we saw. OK. that answers this (it’s just that the FIXME was touched quite recently according to git blame, which is why I asked). thanks Iain _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
