NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
LGTM, let's land asap!
================
Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:65-71
+// Compares AST nodes by source locations.
+template <typename NodeTy> struct CompareNode {
+ bool operator()(const NodeTy *N1, const NodeTy *N2) const {
+ return N1->getBeginLoc().getRawEncoding() <
+ N2->getBeginLoc().getRawEncoding();
+ }
+};
----------------
Nice template solution!
Can we keep it in the `.cpp` file? It's not really part of our analysis's user
interface, at least not yet.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145993/new/
https://reviews.llvm.org/D145993
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
