vedgy added a comment. In D143418#4172587 <https://reviews.llvm.org/D143418#4172587>, @aaron.ballman wrote:
> Thank you, this LGTM! I have to head out shortly, so I'll land this on your > behalf tomorrow when I have the time to babysit the postcommit build farm. > However, if you'd like to request commit access for yourself, I think that'd > be reasonable as well: > https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Let me > know which route you'd prefer going. https://llvm.org/docs/Phabricator.html#committing-a-change says: > Using the Arcanist tool can simplify the process of committing reviewed code > as it will retrieve reviewers, the Differential Revision, etc from the review > and place it in the commit message. You may also commit an accepted change > directly using git push, per the section in the getting started guide. But how to use the Arcanist tool to push reviewed changes is not elaborated. As far as I can tell from the Arcanist documentation, if I have the commit in my local //main// branch which is currently checked out, I simply need to run `arc land` without arguments. Hopefully the Git pre-push hook <https://llvm.org/docs/Contributing.html#git-pre-push-hook> I have set up will run in this case. I have no idea how to babysit the postcommit build farm, and so wouldn't commit when you don't have time anyway. I plan to make only one more change to libclang in the foreseeable future, so not sure learning to handle postcommit issues is justified. I'll leave this to your discretion as I have no idea how difficult and time-consuming this work is, compared to learning how to do it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143418/new/ https://reviews.llvm.org/D143418 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
