nickdesaulniers updated this revision to Diff 502821.
nickdesaulniers added a comment.
- rebase, additional unit test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145429/new/
https://reviews.llvm.org/D145429
Files:
clang/test/Sema/inline-asm-validate.c
Index: clang/test/Sema/inline-asm-validate.c
===================================================================
--- clang/test/Sema/inline-asm-validate.c
+++ clang/test/Sema/inline-asm-validate.c
@@ -7,4 +7,8 @@
// Ensure we accept pointer and non-pointer arguments to "p" constrained
// inputs.
asm (""::"p"(t), "p"(p), "p"(&t));
+ // TODO: Ensure we accept p output constraints.
+ asm ("":"=p"(t)); // expected-error{{invalid output constraint '=p' in asm}}
+ asm ("":"=p"(p)); // expected-error{{invalid output constraint '=p' in asm}}
+ asm ("":"=p"(&t)); // expected-error{{invalid output constraint '=p' in asm}}
}
Index: clang/test/Sema/inline-asm-validate.c
===================================================================
--- clang/test/Sema/inline-asm-validate.c
+++ clang/test/Sema/inline-asm-validate.c
@@ -7,4 +7,8 @@
// Ensure we accept pointer and non-pointer arguments to "p" constrained
// inputs.
asm (""::"p"(t), "p"(p), "p"(&t));
+ // TODO: Ensure we accept p output constraints.
+ asm ("":"=p"(t)); // expected-error{{invalid output constraint '=p' in asm}}
+ asm ("":"=p"(p)); // expected-error{{invalid output constraint '=p' in asm}}
+ asm ("":"=p"(&t)); // expected-error{{invalid output constraint '=p' in asm}}
}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
