dang added a comment. In D144940#4158143 <https://reviews.llvm.org/D144940#4158143>, @Arsenic wrote:
> In D144940#4158020 <https://reviews.llvm.org/D144940#4158020>, @dang wrote: > >> Nice! glad to see this getting fixed. You should add a lit test to ensure we >> don't regress this behavior in the future. > > I see a test checking for availability attribute already exists ( > `clang/test/ExtractAPI/availability.c` ) would it be better if I update it > with another function having a platform specific unavailability attribute or > should I create a new test file ? Yes I think updating that test with another API that has a platform specific unavailability attribute is the best way to do this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144940/new/ https://reviews.llvm.org/D144940 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
