agozillon added a comment. In D144864#4156764 <https://reviews.llvm.org/D144864#4156764>, @jdoerfert wrote:
> Tests? Happy to add more, I am just a little unsure what the best way to test this is other than application of the attribute to the module when the flag was used and verification that the flag was active in FC1, do you have any suggestions? I don't really think there is a way to test for the attribute in OpenMP/invalid.mlir (as no specified verifier) or in OpenMP/ops.mlir as it is not a predefined operation or attribute, but I can look at how fir.kindmap (which is applied similarly) is tested and see if they do anything particular. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144864/new/ https://reviews.llvm.org/D144864 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
