0xdc03 added a comment. I will try to come up with a better diagnostic for this issue and will try and update the patch as soon as I can.
In D143803#4150423 <https://reviews.llvm.org/D143803#4150423>, @aaron.ballman wrote: > Btw, these changes should come with a release note as well. Are all functional changes logged in the release notes? I am not really aware of how they work. ================ Comment at: clang/lib/CodeGen/CodeGenModule.cpp:345 + const llvm::GlobalValue *&GV, + const llvm::MapVector<GlobalDecl, StringRef> &MangledDeclNames) { GV = getAliasedGlobal(Alias); ---------------- aaron.ballman wrote: > Does clang-format do this? It looks far beyond the usual 80 col limit we use. It is beyond the 80 column limit because I formatted it by hand. The linting part of `arc diff` did not complain so it seemed fine to me. I suppose I was supposed to use `git clang-format`, I was not aware of it. I will use that command from now on. ================ Comment at: clang/lib/CodeGen/CodeGenModule.cpp:359-360 + if (ND->getName() == GV->getName()) { + Diags.Report(Location, diag::note_alias_requires_mangled_name) + << GV->getName() << Name; + } ---------------- aaron.ballman wrote: > Should this come with a fix-it to switch the attribute to using the mangled > name instead? I did consider it, however I have no idea how to implement that 😅 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143803/new/ https://reviews.llvm.org/D143803 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
