aaron.ballman added inline comments. ================ Comment at: clang-tidy/modernize/DeprecatedHeadersCheck.cpp:79 @@ -69,3 +78,3 @@ for (const auto &KeyValue : std::vector<std::pair<llvm::StringRef, std::string>>( {{"fenv.h", "cfenv"}, ---------------- omtcyfz wrote: > aaron.ballman wrote: > > This will definitely fail in MSVC 2013. > See the left side of `diff`. It already is in source tree, buildbots never > complained. > > Thus, it won't. Ah shoot, I was misremembering a different case with a similar construct, except it was using std::make_pair, which caused deduction to fail. Le sigh.
https://reviews.llvm.org/D17990 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits